Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newline at the end of go.mod #915

Merged
merged 1 commit into from
Jul 17, 2019
Merged

Newline at the end of go.mod #915

merged 1 commit into from
Jul 17, 2019

Conversation

roberthbailey
Copy link
Member

As per the contributing guide at https://github.com/googleforgames/agones/blob/master/CONTRIBUTING.md#formatting

(my IDE did this for me after enabling go module support).

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4d5387f9-52a5-495c-aee3-99df0a3b04b8

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/915/head:pr_915 && git checkout pr_915
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.12.0-e586d5f

cyriltovena
cyriltovena approved these changes Jul 17, 2019
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roberthbailey roberthbailey merged commit 187e816 into googleforgames:master Jul 17, 2019
@roberthbailey roberthbailey added this to the 0.12.0 milestone Jul 26, 2019
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Aug 1, 2019
@roberthbailey roberthbailey deleted the newline branch August 1, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@roberthbailey @agones-bot @cyriltovena @markmandel